Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor ROS2SpawnerComponent #26

Open
wants to merge 6 commits into
base: forward_branch_wp2
Choose a base branch
from
Open

refactor ROS2SpawnerComponent #26

wants to merge 6 commits into from

Commits on Aug 14, 2023

  1. Add spawner interface to allow selection of spawn points (o3de#343) 

    * Add spawner interface to allow selection of spawn points

Signed-off-by: Artur Kamieniecki <[email protected]>
    @arturkamieniecki @zakmat
    arturkamieniecki authored and zakmat committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    89987b3 View commit details
    Browse the repository at this point in the history

  2. refactor ROS2SpawnerComponent 

    * add m_namespace so multiple Spawners can be defined without collisions
* treat typo in spawn point name as error instead of creating in initial_pose
* make code more idiomatic - use ROS2Conversion utils, structured bindings, avoid map double-lookups

Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    c3fa935 View commit details
    Browse the repository at this point in the history

  3. correct the constness of callbacks 

    Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ea777c2 View commit details
    Browse the repository at this point in the history

  4. replace deprecated GetWorldProperties with GetModelList 

    Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    b5edfb5 View commit details
    Browse the repository at this point in the history

  5. uniquely distinguish spawnables even when without Frame Component 

    * allow spawning non-ROS prefabs in the scene e.g. parts of envirionment
* use robot_namespace request field to customize name of the spawnable

Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    1649f46 View commit details
    Browse the repository at this point in the history

  6. allow customized names for spawnables with simulated bodies 

    Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    c1b4fd8 View commit details
    Browse the repository at this point in the history