Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pointcloud_preprocessor prefix package and namespace with autoware #15

Conversation

@amadeuszsz
Copy link
Contributor Author

memo: wait for autoware.universe merge first

Copy link

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e_simulator.launch.xml was tested and the operation is confirmed.

@shmpwk
Copy link
Collaborator

shmpwk commented Jul 22, 2024

@amadeuszsz @technolojin
Do you think we can merge now or should we wait for tier4/AWSIM#334 ?

@amadeuszsz
Copy link
Contributor Author

@amadeuszsz @technolojin Do you think we can merge now or should we wait for tier4/AWSIM#334 ?

@shmpwk
Yes. Parent PR (already merged) refers only to package's namespace. Without merging this PR, e2e_simulator.launch.xml will fail for now on main branch since pointcloud_preprocessor package does not exist with this name anymore.

@shmpwk
Copy link
Collaborator

shmpwk commented Jul 22, 2024

Thank you, I'll merge this.

@shmpwk shmpwk merged commit d048e14 into RobotecAI:main Jul 22, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants