Use ament_python to build packages rather than ament_cmake #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring compatibility with Python <3.9.
…some of these files aren't touched in this branch.)
…e with find_packages)
|
This PR includes the changes from #938, since they were needed to run under Windows for testing. That PR should probably be merged first. |
sea-bass
requested changes
Aug 14, 2024
…bTools#945) (RobotWebTools#946) Signed-off-by: Brad Martin <[email protected]>
…botWebTools#947) (RobotWebTools#948) If a client asks to subscribe to the same topic more than once, then disconnects, only a pending 'new' subscription may get deleted, leaving the 'old' subscription active indefinitely. Signed-off-by: Brad Martin <[email protected]>
…Tools#949) Add whitespace in front of all ROS action operations -- for correct indentation in Markdown
These should be fixed, thanks. |
|
There are also some merge conflicts to address (sorry, I merged a bunch of PRs recently) |
…some of these files aren't touched in this branch.)
…e with find_packages)
Just rebased and merged. Hopefully this does it. |
|
Weirdly enough, it also shows a bunch of other changes which seem to undo/repeat some of the small PRs that recently went in ... did you rebase on the latest version of the upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Change the build system for these packages from
ament_cmaketoament_python. This is the suggested way to build Python packages for ROS2, and is needed for them to work under Windows.rosapirosbridge_serverThe build system for
rosbridge_libraryis left alone in this PR, since it doesn't have any scripts that need to be executable. However, it could also be converted for consistency.This should resolve #914 and resolve #921.
I've verified that this test launch file works on Windows with Jazzy: