fix: sunset NEAR conversion for now #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
kevindavee,
leoslr,
MantisClone and
olivier7delf
yomarion
requested review from
alexandre-abrioux
and removed request for
kevindavee
alexandre-abrioux
approved these changes
Dec 18, 2023
leoslr
approved these changes
Dec 18, 2023
olivier7delf
approved these changes
Dec 19, 2023
MantisClone
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
The previous oracle we implemented is down. We should investigate supporting Pyth network instead.
Removed:
Attempts to pay a Near request with conversion throws with
Payments with on-chain conversions are currently disabled on Near.More details
Removing Near pairs is debatable, it's quite likely that we will add them back soon. If we think of this array as a stable default set on top of which implementers add their implementations, it's a poor choice and it's up to implementers to remove these values from the default values.