Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy on mantle and mantle testnet #1127

Merged
merged 21 commits into from
Jul 25, 2023
Merged

Conversation

MantisClone
Copy link
Member

@MantisClone MantisClone commented Jul 19, 2023

Description of the changes

@coveralls
Copy link

coveralls commented Jul 19, 2023

Coverage Status

coverage: 87.484%. remained the same when pulling 454b13c on deploy-mantle-testnet into d606fc7 on master.

@MantisClone MantisClone changed the title feat: deploy on mantle "wadsley" testnet feat: deploy on mantle mainnet and mantle "wadsley" testnet Jul 24, 2023
@MantisClone MantisClone changed the title feat: deploy on mantle mainnet and mantle "wadsley" testnet feat: deploy on mantle mainnet and testnet Jul 24, 2023
@MantisClone MantisClone changed the title feat: deploy on mantle mainnet and testnet feat: deploy on mantle and mantle testnet Jul 24, 2023
@MantisClone MantisClone marked this pull request as ready for review July 24, 2023 22:52
packages/currency/src/native.ts Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to version this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think this file needs to be versioned. We edit the create2ContractDeploymentList based on which contracts we're trying to deploy.

If you're asking about "create2" in the filename, that's referring to the CREATE2 opcode which is one of the key ingredients to the xdeployer which makes our smart contract addresses the same across multiple chains.

try {
const RequestDeployer = await hre.ethers.getContractAt(
'RequestDeployer',
'0xE99Ab70a5FAE59551544FA326fA048f7B95A24B2',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this address?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the address of the RequestDeployer contract, same on all networks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be a variable or should have a comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one in the hardhat config file actually. Maybe we should put it elsewhere and export it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Okay I'll fix this.

@MantisClone MantisClone merged commit d539717 into master Jul 25, 2023
1 check passed
@MantisClone MantisClone deleted the deploy-mantle-testnet branch July 25, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants