fix(gas-fee): catch estimation errors #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
kevindavee,
KolevDarko,
MantisClone and
olivier7delf
benjlevesque
approved these changes
Jun 30, 2023
kevindavee
approved these changes
Jun 30, 2023
benjlevesque
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
It can happen, rarely, that
@rainbow-me/fee-suggestionsfails to estimate gas fees, especially on chains other than Ethereum mainnet (related to rainbow-me/fee-suggestions#23).This PR catches, logs, and handles those errors by returning an empty object, thus letting the RPC provider choose how to configure gas fee / gas price (either by using defaults for the EIP-1559 transaction fields or falling back to a legacy, non-EIP 1559, transaction).