fix: Revert Pay before Persist experiment (#1387)

RequestNetwork · Apr 10, 2024 · 6cf66fb · 6cf66fb
1 parent a184887
commit 6cf66fb
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/packages/request-client.js/src/api/request-network.ts b/packages/request-client.js/src/api/request-network.ts
@@ -31,9 +31,9 @@ export default class RequestNetwork {
   public paymentNetworkFactory: PaymentNetworkFactory;
   public supportedIdentities: IdentityTypes.TYPE[] = supportedIdentities;
 
-  public requestLogic: RequestLogicTypes.IRequestLogic;
-  public transaction: TransactionTypes.ITransactionManager;
-  public advancedLogic: AdvancedLogicTypes.IAdvancedLogic;
+  private requestLogic: RequestLogicTypes.IRequestLogic;
+  private transaction: TransactionTypes.ITransactionManager;
+  private advancedLogic: AdvancedLogicTypes.IAdvancedLogic;
 
   private contentData: ContentDataExtension;
   private currencyManager: ICurrencyManager;
@@ -374,7 +374,7 @@ export default class RequestNetwork {
    * @param parameters Parameters to create a request
    * @returns the parameters, ready for request creation, the topics, and the paymentNetwork
    */
-  public async prepareRequestParameters(parameters: Types.ICreateRequestParameters): Promise<{
+  private async prepareRequestParameters(parameters: Types.ICreateRequestParameters): Promise<{
     requestParameters: RequestLogicTypes.ICreateParameters;
     topics: any[];
     paymentNetwork: PaymentTypes.IPaymentNetwork | null;

diff --git a/packages/request-logic/src/request-logic.ts b/packages/request-logic/src/request-logic.ts
@@ -16,8 +16,8 @@ import { normalizeKeccak256Hash, notNull, uniqueByProperty } from '@requestnetwo
  * Implementation of Request Logic
  */
 export default class RequestLogic implements RequestLogicTypes.IRequestLogic {
-  public advancedLogic: AdvancedLogicTypes.IAdvancedLogic | undefined;
-  public transactionManager: TransactionTypes.ITransactionManager;
+  private advancedLogic: AdvancedLogicTypes.IAdvancedLogic | undefined;
+  private transactionManager: TransactionTypes.ITransactionManager;
   private signatureProvider: SignatureProviderTypes.ISignatureProvider | undefined;
 
   public constructor(
@@ -386,7 +386,7 @@ export default class RequestLogic implements RequestLogicTypes.IRequestLogic {
    *
    * @returns the request id, the action and the hashed topics
    */
-  public async createCreationActionRequestIdAndTopics(
+  private async createCreationActionRequestIdAndTopics(
     requestParameters: RequestLogicTypes.ICreateParameters,
     signerIdentity: IdentityTypes.IIdentity,
     topics: any[],
@@ -665,7 +665,7 @@ export default class RequestLogic implements RequestLogicTypes.IRequestLogic {
    *
    * @returns void, throws if the action is invalid
    */
-  public async validateAction(
+  private async validateAction(
     requestId: RequestLogicTypes.RequestId,
     action: RequestLogicTypes.IAction,
   ): Promise<void> {

diff --git a/packages/transaction-manager/src/transaction-manager.ts b/packages/transaction-manager/src/transaction-manager.ts
@@ -16,8 +16,8 @@ import TransactionsFactory from './transactions-factory';
  * Implementation of TransactionManager layer without encryption
  */
 export default class TransactionManager implements TransactionTypes.ITransactionManager {
-  public dataAccess: DataAccessTypes.IDataAccess;
-  public channelParser: ChannelParser;
+  private dataAccess: DataAccessTypes.IDataAccess;
+  private channelParser: ChannelParser;
 
   public constructor(
     dataAccess: DataAccessTypes.IDataAccess,