Web Scrobbler classes to add #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry I slipped on this, merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to Web UI outputting raw Tailwind #69
I added the classes that would be necessary to get @web-scrobbler working again on the site. I did this blind without running the actual build, so would be worth verifying that this would all work, or if there are conditions like mobile views that I might not have considered.
These classes should mirror structurally the way the site was previously.
The only change that gave me pause was the play/pause button class. You're using FontAwesome and the
fasclass is an old reference to the solid icons, which is seems that you're using. So addingfaswould probably make thefaredundant.