add currently downloading badge to downloads tab #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a look at #42 I first tried adding some text to the bottom tab. This looked a bit cluttered and was hard to read. Instead, I added a badge which displays a number indicating how many tracks are currently downloading. It is removed once all tracks have finished downloading.
Additionally, I changed the text on the tab from "Downloaded" to "Downloads" as that made more sense to me. Happy to revert this if desired.
Screenshot
Demo
Showing the final download completing
https://github.com/user-attachments/assets/5ea0e226-d8b7-4341-9a2d-546964f12fe2