1.20.3/4 support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xGab0
commented
Dec 7, 2023
xGab0
commented
- updated Minecraft to 1.20.3/4
- updated Fabric loader to 0.15.0
- updated Gradle to 8.5
- imports cleanup
- fixed a mixin
- updated Minecraft to 1.20.3/4 - updated Fabric loader to 0.15.0 - updated Gradle to 8.5 - imports cleanup - fixed a mixin
ishland
requested changes
Dec 8, 2023
Comment on lines
-19
to
+25
| @Shadow public abstract void onSoundPlayed(SoundInstance sound, WeightedSoundSet soundSet); | ||
| @Shadow public abstract void onSoundPlayed(SoundInstance sound, WeightedSoundSet soundSet, float range); | ||
|
|
||
| @Inject(method = "onSoundPlayed", at = @At("HEAD"), cancellable = true) | ||
| private void onSoundPlayedHandler(SoundInstance sound, WeightedSoundSet soundSet, CallbackInfo ci) { | ||
| private void onSoundPlayedHandler(SoundInstance sound, WeightedSoundSet soundSet, float range, CallbackInfo ci) { | ||
| if (!this.client.isOnThread()) { | ||
| ci.cancel(); | ||
| this.client.execute(() -> this.onSoundPlayed(sound, soundSet)); | ||
| this.client.execute(() -> this.onSoundPlayed(sound, soundSet, range)); |
There was a problem hiding this comment.
This breaks backward-compatibility for versions earlier than 1.20.3.
There was a problem hiding this comment.
I'm not sure what to do here, from my understanding this Mixin is required for mc1.20.3+ since Mojang changed the method to pass a range field, otherwise the game will crash.
ishland
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.