Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coretime market pallet #136

Merged
merged 46 commits into from
May 26, 2024
Merged

Coretime market pallet #136

merged 46 commits into from
May 26, 2024

Conversation

Szegoo
Copy link
Member

@Szegoo Szegoo commented May 19, 2024

TODOs:

  • tests
  • benchmarks
  • generate weights
  • allow access through XCM (We already allow any incoming XCM execution since we don't have a SafeCallFilter). We should write an e2e test for this in a separate PR.
  • docs

Copy link
Member Author

@Szegoo Szegoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good

pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/tests.rs Outdated Show resolved Hide resolved
pallets/market/src/tests.rs Show resolved Hide resolved
pallets/market/src/tests.rs Show resolved Hide resolved
@Szegoo Szegoo marked this pull request as ready for review May 25, 2024 12:15
pallets/market/src/benchmarking.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
@Szegoo Szegoo merged commit fea7066 into main May 26, 2024
5 checks passed
@Szegoo Szegoo deleted the market-pallet branch June 2, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants