Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added healthcheck and conditions per container #15

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

vladvildanov
Copy link
Collaborator

No description provided.

@@ -6,7 +6,6 @@ fi

## Build infrastructure ##
docker-compose up -d
sleep 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you still need the sleep, since it takes time to settle. Healthcheck + sleep?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, each container runs only if previous is "healthy", in this case it means that REST API is accessible. When we creating cluster we only care about master-node to be "healthy" cause we're making a REST API call to it

@vladvildanov vladvildanov merged commit 66ef8c5 into main Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants