Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage-benchmark: Force LANG to avoid errors in floating point printf #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

storage-benchmark: Force LANG to avoid errors in floating point printf #82

wants to merge 1 commit into from

Conversation

andreamtp
Copy link

@andreamtp andreamtp commented Jul 12, 2022 •
edited
Loading

Force LANG to avoid errors in floating point printf for memory rounding.

fix issue #80

@andreamtp andreamtp mentioned this pull request Jul 12, 2022
Closed
@andreamtp andreamtp changed the title storage-benchmark: Ensure memory math works as expected storage-benchmark: Force LANG to avoid errors in floating point printf Jul 12, 2022
pablomh added a commit that referenced this pull request Mar 26, 2024
@pablomh
fix(storage-benchmark): Fix RAMGB calculation
fdff1e6 
The previous calculation not always resulted in an integer, which wasn't what it was expected, and failed with some locales.

- Fixes: #80

- Based on input from #82 and #88.
@pablomh
Copy link
Collaborator

pablomh commented Mar 26, 2024

Hopefully fdff1e6 will address this issue.

Please, create a new issue if it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreamtp @pablomh