Add Zeitwerk loader support #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofedoren
force-pushed
the
feat-support-zeitwerk
branch
2 times, most recently
from
2473158
to
03110b9
Compare
ofedoren
force-pushed
the
feat-support-zeitwerk
branch
2 times, most recently
from
e19c1f4
to
298925e
Compare
evgeni
force-pushed
the
feat-support-zeitwerk
branch
from
298925e
to
ae70164
Compare
ekohl
approved these changes
Sep 10, 2024
evgeni
reviewed
Sep 10, 2024
evgeni
force-pushed
the
feat-support-zeitwerk
branch
from
ae70164
to
5399608
Compare
|
Any idea why the link test now fails? |
|
Isn't this because something wasn't updated for the tests? Like #70 |
|
No |
I think the way it gets loaded doesn't work. The rake task doesn't load the whole Rails environment but loads one file directly. In #58 I've taken a more native approach, but I still have to finish that. |
evgeni
force-pushed
the
feat-support-zeitwerk
branch
from
5399608
to
352cec9
Compare
evgeni
reviewed
Sep 11, 2024
test/link_checker.rb
Outdated
| @@ -47,7 +47,7 @@ def navigate_path(path, hash = @toc) | |||
|
|
|||
| inner_hash = hash[first] | |||
|
|
|||
| return inner_hash if rest.empty? | |||
| return inner_hash if rest.nil? or rest.empty? | |||
There was a problem hiding this comment.
Before Zeitwerk, Rails was loaded when this test was running and Rails in its endless wisdom adds empty? to NilClass. With Zeitweirk, no Rails is present here, and so no NilClass.empty?. Let's catch that via nil? first.
evgeni
force-pushed
the
feat-support-zeitwerk
branch
from
352cec9
to
3f0595f
Compare
ekohl
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.