Skip to content

Commit

Permalink
Expose multi-CV feature downstream
Browse files Browse the repository at this point in the history
  • Loading branch information
jeremylenz committed Sep 30, 2024
1 parent 6d995cc commit d029292
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
9 changes: 7 additions & 2 deletions app/models/concerns/upstream_only_settings.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Settings to hide in downstream (will return nil for all values)
module UpstreamOnlySettings
class UpstreamOnlySettings
SETTINGS = %w[
allow_multiple_content_views
].freeze

def self.include?(key)
new.include?
def include?(key)
SETTINGS.include?(key.to_s)
end
end
8 changes: 5 additions & 3 deletions test/unit/setting_registry_branding_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,16 @@ class SettingRegistryBrandingTest < ActiveSupport::TestCase
end

test 'hides upstream-only settings' do
assert_nil Setting['allow_multiple_content_views']
UpstreamOnlySettings.expects(:include?).with('test_setting').returns(true)
assert_nil Setting['test_setting']
end
end
end

class SettingBrandingTest < ActiveSupport::TestCase
test 'replaces warning for upstream-only settings' do
Rails.logger.expects(:debug).with('Setting \'allow_multiple_content_views\' is not available in Satellite; ignoring')
Setting['allow_multiple_content_views']
UpstreamOnlySettings.expects(:include?).with('test_setting').returns(true)
Rails.logger.expects(:debug).with('Setting \'test_setting\' is not available in Satellite; ignoring')
Setting['test_setting']
end
end

0 comments on commit d029292

Please sign in to comment.