Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: build & test also on centos-stream-10 #150

Merged
merged 2 commits into from
Oct 7, 2024
Merged

ci: build & test also on centos-stream-10 #150

merged 2 commits into from
Oct 7, 2024

Conversation

ptoscano
Copy link
Contributor

@ptoscano ptoscano commented Oct 4, 2024

Factorize the existing tests blocks for centos-stream first, so adding the new version is easier.

jirihnidek
jirihnidek reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we drop support for centos-stream-8 ? It is not supported anymore, right? I can still see it in the "targets".

BTW: I remember that we had some good reason for not using $release in the id, but it seems that it works now.

@ptoscano
Copy link
Contributor Author

ptoscano commented Oct 4, 2024

Shouldn't we drop support for centos-stream-8 ? It is not supported anymore, right? I can still see it in the "targets".

That's a separate discussion, this is focusing only on c10s.

@ptoscano
ci: de-duplicate packit testing-farm configs for centos-stream
1d8cc13 
Use a single block of tests for all the versions of centos-stream, using
the "$releasever" RPM variable.

There is no change to the actual tests being run.
@ptoscano
ci: build & test also on centos-stream-10
2ca956c
jirihnidek
jirihnidek approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jirihnidek jirihnidek merged commit ff915cb into RedHatInsights:main Oct 7, 2024
25 of 26 checks passed
@ptoscano ptoscano deleted the packit-c10s branch October 7, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirihnidek jirihnidek jirihnidek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptoscano @jirihnidek