fix: Printing JSON document & printing error #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jirihnidek
commented
Sep 12, 2024
jirihnidek
commented
- There were one edge case, when not only JSON document was printed to stdout, and some user input was required. This case happened, when user is member of more organizations and --organization was not specified using CLI option
- Do not print error message, when no format is specified
- When no --username/--password is specified and --format json is used, then do not ask for input, but print some error.
jirihnidek
force-pushed
the
jhnidek/fix_connect_format_json
branch
from
14a5197
to
db4f870
Compare
jirihnidek
changed the title
subpop
requested changes
Oct 4, 2024
main.go
Outdated
| return fmt.Errorf("--password is required, when --username and machine-readable format are used") | ||
| } | ||
| if username == "" || password == "" { | ||
| return fmt.Errorf("--username/--password or --organization/--activation-key are required, when machine-readable format is used") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("--username/--password or --organization/--activation-key are required, when machine-readable format is used") | |
| return fmt.Errorf("--username/--password or --organization/--activation-key are required when a machine-readable format is used") |
Minor grammatical changes to error message.
* There were one edge case, when not only JSON document was printed to stdout, and some user input was required. This case happened, when user is member of more organizations and --organization was not specified using CLI option * Do not print error message, when no format is specified * When no --username/--password is specified and --format json is used, then do not ask for input, but print some error.
jirihnidek
force-pushed
the
jhnidek/fix_connect_format_json
branch
from
db4f870
to
d4b496d
Compare
subpop
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.