This repository has been archived by the owner on Aug 10, 2024. It is now read-only.
Return an unexpected response if the redirect its the same that the original url #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the same that the original url
brentsimmons
suggested changes
May 13, 2023
| @@ -104,10 +104,21 @@ extension DownloadSession: URLSessionTaskDelegate { | |||
|
|
|||
| if response.statusCode == 301 || response.statusCode == 308 { | |||
| if let oldURLString = task.originalRequest?.url?.absoluteString, let newURLString = request.url?.absoluteString { | |||
| cacheRedirect(oldURLString, newURLString) | |||
| guard oldURLString != newURLString else { | |||
There was a problem hiding this comment.
Would you rewrite this as if oldURLString == newURLString {? This would make it easier to understand for future people reading the code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an issue with an url (https://hipertextual.com/feed). Every time that I tried to get the articles, this endpoint redirects, several times to the same url.
This little update help to avoid the problem where the redirect url is the same that the original and returns an error.