Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility fixes for PHP 8.2 #285

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Compatibility fixes for PHP 8.2 #285

wants to merge 3 commits into from

Conversation

s1shed
Copy link

@s1shed s1shed commented Jul 4, 2023

This fixes various warnings and errors in PHP 8.2 and is intended to complement #282.

@infrastation
Copy link
Member

Thank you, that's a large diff, please let me have some time to proof-read the changes.

@s1shed
Copy link
Author

s1shed commented Jul 5, 2023

No problem, hopefully it's of use. :)

Just stumbled on this with PHP 8.2:

Deprecated: Function strftime() is deprecated in /racktables/wwwroot/inc/functions.php on line 6374

@infrastation
Copy link
Member

infrastation commented Jul 9, 2023 •
edited
Loading

That's a separate problem and it will take a separate solution (replace strptime() and strftime() with something and something else), but thank you for bringing this up.

@andypost
Copy link

this functions are deprecated in 8.1.0

This function has been deprecated. Use date_parse_from_format() instead (for locale-independent parsing), or IntlDateFormatter::parse() (for locale-dependent parsing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimda7 nimda7 nimda7 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s1shed @infrastation @andypost @nimda7