Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to add tags to objects, racks and ipv4 networks + some doc updates + reports directory fixup #43

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

matt32106
Copy link
Contributor

No description provided.

@infrastation
Copy link
Member

Thank you for suggesting this contribution. It looks like sara-nl#6 implements this functionality in a more generic way, have you looked at that proposed change?

@matt32106
Copy link
Contributor Author

matt32106 commented Jun 8, 2020

Thanks for the heads up, this looks interesting, I'll have a closer look. I find it disturbing to not have all effort stored in one repo, is there a list of all the active repos for racktables & plugins somewhere?

@infrastation
Copy link
Member

Not as far as I know. I'd rather forward-port these old PRs into this new copy of this plugin and have only one copy to worry about.

@matt32106 matt32106 changed the title Add the capability to add a tag when creating an IP prefix Add capability to add tags to objects, racks and ipv4 networks + some doc updates + reports directory fixup Jun 19, 2020
@matt32106
Copy link
Contributor Author

matt32106 commented Jun 19, 2020

Hi Denis, I have integrated the changes you suggested and fixed the directory nesting in the reports plugin. Talking about reports, this version of the addon is really great and should be pushed upstream IMO (+ it would solve the hurdle of the manual copy of various files to install it). Also maybe it would be worthwhile to specify somewhere (repo README?) which plugins are 0.21's plugin format compatible.

@matt32106 matt32106 force-pushed the master branch 2 times, most recently from 20e2b74 to bbf2f37 Compare June 23, 2020 14:52
@matt32106
Copy link
Contributor Author

matt32106 commented Jun 23, 2020

I did some cleanup in the commits mess and added author for TAG (still learning git, sry...). Let me know if you need more udpates. BR

@matt32106
Copy link
Contributor Author

Ping...

@infrastation
Copy link
Member

Excuse me, I had other things to sort. I am going to make another look soon.

@matt32106
Copy link
Contributor Author

No worries :)

@infrastation
Copy link
Member

I am expecting to start this after finishing another work in about a week.

@infrastation
Copy link
Member

That was very optimistic, please excuse me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants