Feature/extend osc support #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fails due to this issue in scenariogeneration pyoscx/scenariogeneration#243 |
samuelthoren
approved these changes
Aug 22, 2024
| ros__parameters: | ||
| open_scenario_file: "scenario_name.xosc" # The name of the scenario to open. Located in the ~/.astazero/ATOS/osc directory. | ||
| active_object_names: ["object1", "object2"] # List of object names to be active in the scenario. An empty list means all objects are active. |
There was a problem hiding this comment.
Just a thought, should it be possible to have zero objects active?
Comment on lines
4
to
11
| class CustomCommandAction: | ||
| def __init__(self, type: str, content: str): | ||
| self.type = type | ||
| self.content = content | ||
|
|
||
| def __eq__(self, other): | ||
| return self.type == other.type and self.content == other.content | ||
|
|
There was a problem hiding this comment.
This deviates from how we handle ros channels in c++, maybe this class could be put somewhere else to promote uniformity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces CustomCommandActions to ATOS which enables the user to specify add arbitrary actions to a scenario file and make ATOS publish the type and content of these actions in a ROS message of type CustomCommandAction.
The previous V2X/DEMN functionality is ported this new way of working and new REST gateway is added to enable the sending REST requests, triggered by a CustomCommandAction.