Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/configpanel #620

Merged
merged 40 commits into from
Jan 22, 2024
Merged

Feature/configpanel #620

merged 40 commits into from
Jan 22, 2024

Conversation

SebastianSvanland
Copy link
Contributor

@SebastianSvanland SebastianSvanland commented Dec 20, 2023

New config panel. Go to localhost:3000/configpanel to try it out. No ATOS modules support this gui so far, but the ROS parameters are requested from each node at least. Needed to do some restructuring in the previous controlpanel as well so this PR works towards multiple tickets.

I've been working on this for a while now so I've gone blind for all the variable/function names. Would appreciate if someone could help me clean it up, right now it's a mess. Also check the descriptions/title of all the parameters, I didn't fully understand what all of them did so I just made something up for now. You can either see this in the gui immediately when entering value for each parameter, or check out json-schema

There is a known issue where the config gui doesn't send the ros parameters for all nodes. Don't really know why that is yet.

SebastianSvanland and others added 30 commits December 12, 2023 08:59
@SebastianSvanland SebastianSvanland requested a review from a team December 20, 2023 22:26
@samuelthoren
Copy link
Contributor

Looks really good, nice work!

Here's a very short review, we can continue reviewing this in January.

  • The structure can maybe be improved. Now we have gui/controlpanel and gui/src, which might be confusing. Maybe we should have a controlpanel directory and a configpanel directory, and a directory for the shared code or something like that.
  • Make it possible to fetch the parameters that are loaded to ATOS, right now it shows the default parameters from the repo.
  • Some input about the tabs:
    • Is it possible to set the default directory that opens when you press Browse... to ~/.astazero/ATOS/ instead?
    • When loading for instance an .xosc-file, does this it send the full path or only the name? We append ~/.astazero/ATOS/osc/ in EsminiAdapter and if it sends the full path this is not going to work. Maybe a feature that should be added in another PR is to being able to load a scenario file that is located anywhere and not only in ~/.astazero/ATOS/osc/.
    • I think the integration testing tab is a bit unclear. Is it possible to make it more like the pointcloud tab where you can add and subtract items, and maybe select from pre-defined scenarios?

@victorjarlow victorjarlow changed the base branch from dev to node_based_gui January 17, 2024 20:15
gui/src/public/javascripts/configClient.js Outdated Show resolved Hide resolved
gui/src/views/configpanel.pug Outdated Show resolved Hide resolved
gui/src/public/javascripts/configClient.js Outdated Show resolved Hide resolved
gui/src/public/javascripts/configClient.js Outdated Show resolved Hide resolved
gui/src/public/javascripts/configClient.js Outdated Show resolved Hide resolved
gui/src/ros_nodes/config_node.js Show resolved Hide resolved
gui/src/ros_nodes/config_node.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@victorjarlow victorjarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SebastianSvanland SebastianSvanland merged commit b89941e into node_based_gui Jan 22, 2024
1 check passed
@SebastianSvanland SebastianSvanland deleted the feature/configpanel branch January 22, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants