-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/configpanel #620
Merged
Merged
Feature/configpanel #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructure for jsonForm).
…nstead of keeping it as submodule.
Looks really good, nice work! Here's a very short review, we can continue reviewing this in January.
|
victorjarlow
requested changes
Jan 22, 2024
Co-authored-by: victorjarlow <[email protected]>
Co-authored-by: victorjarlow <[email protected]>
Co-authored-by: victorjarlow <[email protected]>
victorjarlow
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New config panel. Go to localhost:3000/configpanel to try it out. No ATOS modules support this gui so far, but the ROS parameters are requested from each node at least. Needed to do some restructuring in the previous controlpanel as well so this PR works towards multiple tickets.
I've been working on this for a while now so I've gone blind for all the variable/function names. Would appreciate if someone could help me clean it up, right now it's a mess. Also check the descriptions/title of all the parameters, I didn't fully understand what all of them did so I just made something up for now. You can either see this in the gui immediately when entering value for each parameter, or check out json-schema
There is a known issue where the config gui doesn't send the ros parameters for all nodes. Don't really know why that is yet.