Add scroll speed factor info for changing scroll speed multiplier in map #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
5 tasks
# Conflicts: # Quaver.API/Maps/Qua.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scroll speed factor changes can introduce parallax effects and help making some SV effects more smooth.
Current implementation consists of a list of factors that are lerped in time (excluding start and end). Each factor info has a
LaneMaskfield, that is a bitwise mask of the lanes (0-indexed) that are affected by this factor,ith bit for theith lane:-1applies to all lanes,-56(1111...1001000) for the 4th and 7th lane in a 7k map (1-indexed). This way we are able to have separate factor changes per lane.