WIPEOUT: reduce chances of repeat spawn locations #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsvensson
reviewed
Sep 20, 2024
| @@ -1249,7 +1249,7 @@ gedict_t* SelectSpawnPoint(char *spawnname) | |||
| gedict_t *spot = Sub_SelectSpawnPoint(spawnname); | |||
|
|
|||
| // k_spw 4 feature, recheck spawn poit second time if we select same spawn point in row, so it low chance to get same spawn point | |||
| if ((match_in_progress == 2) && (k_lastspawn == spot) && (cvar("k_spw") == 4)) | |||
| if ((match_in_progress == 2) && (k_lastspawn == spot) && (cvar("k_spw") == 4 || cvar("k_clan_arena") == 2)) | |||
There was a problem hiding this comment.
checking https://github.com/QW-Group/ktx/blob/master/src/commands.c#L4368-L4391 k_clan_arena is k_spw 1. It looks a bit odd to introduce a mode quirk here, is it perhaps that k_spw needs to evolve a bit instead?
There was a problem hiding this comment.
I feel like it this is less odd than creating a near duplicate of an already uncommon spawn scheme. If there wasn't already one or two other modes using it, I'd just change the behavior of k_spw 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.