Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Windows builds to cmake / mingw. #935

Merged
merged 10 commits into from
Sep 15, 2024
Merged

Switch Windows builds to cmake / mingw. #935

merged 10 commits into from
Sep 15, 2024

Conversation

dsvensson
Copy link
Collaborator

@dsvensson dsvensson commented Sep 7, 2024 •
edited
Loading

  • Cross-compiles from Linux using MinGW which results in a slightly faster CI run.
  • The MinGW build is based on reports quite a bit faster than the msvc build on some hardware, and no regressions reported.
  • Updates the Windows build documentation.
  • Removes redundant Visual Studio related files.

@dsvensson
Copy link
Collaborator Author

dsvensson commented Sep 7, 2024 •
edited
Loading

Verified and thoroughly benchmarked by a number of ppl in the community earlier today.

@dsvensson
Copy link
Collaborator Author

Shallow clones now result the following in addition to setting revision to 0 like before:

CMake Warning at cmake/GitUtils.cmake:41 (message):
  Shallow repository detected, revision not available.
Call Stack (most recent call first):
  CMakeLists.txt:30 (git_extract_version)


-- Version: 20a4b3c (0~20a4b3c99)

@dsvensson dsvensson merged commit a7f5bf1 into QW-Group:master Sep 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsvensson