Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the home directory location (linux only) #791

Closed
wants to merge 1 commit into from

Conversation

krizej
Copy link
Contributor

@krizej krizej commented Jun 30, 2023

move ~/.ezquake to ~/.local/share/ezquake (or $XDG_DATA_HOME/ezquake if set) to avoid being yet another annoying piece of software that crams itself into your home folder :)

@tcsabina
Copy link
Collaborator

tcsabina commented Jul 3, 2023

Hi @krizej,

Have you seen #336? That PR also about this topic, and some additional stuff. Could you guys align on this?

strlcpy(com_homedir, xdg, sizeof(com_homedir));
strlcat(com_homedir, "/ezquake", sizeof(com_homedir));
} else {
strlcat(com_homedir, "/.local/share/ezquake", sizeof(com_homedir));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think many won't like this change. Why the '.local/share' prefix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if XDG_DATA_HOME isn't set, it should default to ~/.local/share

Copy link
Collaborator

@tcsabina tcsabina Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if XDG_DATA_HOME isn't set, it should default to ~/.local/share

I know ;).
But that is exactly why I commented...

Why do you think we need to move the ezquake home directory to '~/.local/share/ezquake'?
What makes you think that this is better, compared to the current one?
Is this your personal taste? Or some kind of "standard" of some linux distro? If yes, which distro? What about other distro's "standard".

You see my point?

Also, as I have indicated, there is another PR open which is tackling these directories under linux. That PR seems to cover much more on top of the "home directory". So I rather wait on that PR to be finalized, instead of just merging this PR that only touches to home directory of ezquake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you think we need to move the ezquake home directory to '~/.local/share/ezquake'?
What makes you think that this is better, compared to the current one?

it follows the XDG spec more closely :P

I rather wait on that PR to be finalized

then have fun waiting, personally i think we will not hear from the author of that pr anytime soon

sorry for the late reply and i guess this pr can be closed then

@krizej krizej closed this Aug 4, 2023
@krizej krizej deleted the xdg branch August 4, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants