Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: subscriptions & related changes #2564

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

feat: subscriptions & related changes #2564

wants to merge 23 commits into from
+442 −54

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Aug 28, 2024 •
edited
Loading

Summary

https://discord.com/developers/docs/change-log#premium-apps-entitlement-migration-and-new-subscription-api

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331 plun1331 added bug Something isn't working documentation Improvements or additions to documentation priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Aug 28, 2024
@plun1331 plun1331 added this to the v2.7 milestone Aug 28, 2024
@plun1331 plun1331 self-assigned this Aug 28, 2024
@plun1331 plun1331 requested a review from a team as a code owner August 28, 2024 22:20
@plun1331
Copy link
Member Author

Untested (because i can't)

Lulalaby
Lulalaby reviewed Aug 28, 2024
View reviewed changes
discord/enums.py Outdated Show resolved Hide resolved
@Lulalaby
Update discord/enums.py
3ad15d6 
Signed-off-by: Lala Sabathil <[email protected]>
@Lulalaby
Copy link
Member

Lulalaby commented Aug 28, 2024 •
edited
Loading

@plun1331 if u want to test it lmk, i have a few apps with monitization ready u could use
tho these changes are being made in future, not sure if we should test it rn

@plun1331
Copy link
Member Author

tested

@plun1331 plun1331 enabled auto-merge (squash) September 19, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

At least 1 approving review is required to merge this pull request.

Assignees

@plun1331 plun1331

Labels
bug Something isn't working documentation Improvements or additions to documentation feature Implements a feature PA: All Contributors pending priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@plun1331 @Lulalaby