Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

karma update messages to dedicated log channel + remove SPECIAL_REPLIES #114

Merged
merged 18 commits into from
Jul 31, 2023
Merged

karma update messages to dedicated log channel + remove SPECIAL_REPLIES #114

merged 18 commits into from
Jul 31, 2023

Conversation

bbelderbos
Copy link
Collaborator

No description provided.

bbelderbos and others added 18 commits October 6, 2021 11:34
@bbelderbos
bump version
b5f3090
@bbelderbos
fix action file
6091f0f
@bbelderbos
Update README.md
a94ef2c
@bbelderbos
Update README.md
5d74fa7
@bbelderbos
Update README.md
2b28576
@bbelderbos
Update .pre-commit-config.yaml
48add01 
PyBites-Open-Source#107
@bbelderbos
Merge branch 'develop'
fce55bd
@bbelderbos
test commit
96dbf17
@bbelderbos
add a runtime
eb41971
@bbelderbos
bug toml file:
3f8fd24 
remote: -----> Add Poetry to the PATH
remote: -----> Export requirements.txt from Poetry
remote:
remote:          TOMLError
remote:
remote:          Invalid TOML file /tmp/build_fd4bfa75/pyproject.toml: Key "name" already exists.
@bbelderbos
another duplicated key:
98c6952 
remote: -----> Add Poetry to the PATH
remote: -----> Export requirements.txt from Poetry
remote:
remote:          TOMLError
remote:
remote:          Invalid TOML file /tmp/build_0b421871/pyproject.toml: Key "version" already exists.
@bbelderbos
Merge branch 'master' of github.com:PyBites-Open-Source/karmabot
068f44f
@bbelderbos
Merge branch 'develop'
4e9e7c0
@bbelderbos
Merge branch 'develop'
4973cda
@bbelderbos
fix for PyBites-Open-Source#103
0969e3f 
bumped version
upgraded pre-commit
pre-commit mypy errors: removed int type hint from KarmaNote + changed | to Union (which should have been supported hm)
@bbelderbos
fix test
6bdb5fd
@bbelderbos
fixes PyBites-Open-Source#113
af6c3f2
@bbelderbos
update readme
32c584d
@bbelderbos
Copy link
Collaborator Author

Not sure why more commits show up but the diff is accurate. I tested it in UAT and works nicely:

Screenshot 2023-07-28 at 19 05 09 Screenshot 2023-07-28 at 19 05 19 Screenshot 2023-07-28 at 19 05 42 Screenshot 2023-07-28 at 19 05 45 Screenshot 2023-07-28 at 19 05 50

@bbelderbos
Copy link
Collaborator Author

@JnyJny logging the channel would be nice, but given current way the code is structured that would require a bigger change I think.

@bbelderbos bbelderbos changed the title Fix karma spam karma update messages to dedicated log channel + remove SPECIAL_REPLIES Jul 28, 2023
@bbelderbos
Copy link
Collaborator Author

@JnyJny logging the channel would be nice, but given current way the code is structured that would require a bigger change I think.

Although we still can if we pass down channel_id into karma.change_karma(... and there pass it through to self._create_msg(.. to make it part of text there, but not sure how useful a Cxyz channel code is (I don't think you get the name of the channel)

JnyJny
JnyJny approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@JnyJny JnyJny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmayd
Copy link
Collaborator

pmayd commented Jul 28, 2023

OK you beat me to it!

@bbelderbos bbelderbos merged commit 680fa3e into PyBites-Open-Source:develop Jul 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JnyJny JnyJny JnyJny approved these changes

@pmayd pmayd Awaiting requested review from pmayd

@pogross pogross Awaiting requested review from pogross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbelderbos @pmayd @JnyJny