Resolve benchmark error #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchmark.sh
Outdated
| @@ -16,7 +16,7 @@ trap cleanup EXIT SIGINT SIGTERM | |||
| # Generate random numbers for insert and find operations | |||
| INSERT_FILE="inserts.json" | |||
| FIND_FILE="finds.txt" | |||
| NUM_ENTRIES=100000 | |||
| NUM_ENTRIES=100 | |||
There was a problem hiding this comment.
Overall looks good to me.
Is there a particular reason you changed the number of entries here?
There was a problem hiding this comment.
No, I changed the value because I wanted to check quickly if we still have an error or not.
alipourhabibi
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where the script
benchmark.shwas failing due to incorrect handling of exit statuses for background processes causing a unary operator expected errorChanges:
Impact: