Don't adjust package UUIDs in bundles #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelHatherly
force-pushed
the
mh/no-uuid-mutation
branch
7 times, most recently
from
c220f37
to
fe8a6ee
Compare
Previously package UUIDs to be bundled had their values altered so that they could live alongside the read version of the package and not conflict. This works fine aside from cases where a package migrates from a private registry into a public one and different environments require versions from different registries. Instead, maintain the same UUIDs, but during installation of a bundle drop versions of bundled packages that already exist within another registry, ie. a user has source access to the package at that version. The resolver will then pick the source available package instead of the bundled one transparently. Required rewrite of the test framework. Now uses a dynamically generated custom registry using `LocalRegistry.jl` with locally registered custom packages that are then bundled. Reduces test runtime significantly for no loss in testing coverage.
MichaelHatherly
force-pushed
the
mh/no-uuid-mutation
branch
from
ebcec5e
to
9433598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously package UUIDs to be bundled had their values altered so that they could live alongside the read version of the package and not conflict. This works fine aside from cases where a package migrates from a private registry into a public one and different environments require versions from different registries. Instead, maintain the same UUIDs, but during installation of a bundle drop versions of bundled packages that already exist within another registry, ie. a user has source access to the package at that version. The resolver will then pick the source available package instead of the bundled one transparently.
Required rewrite of the test framework. Now uses a dynamically generated custom registry using
LocalRegistry.jlwith locally registered custom packages that are then bundled. Reduces test runtime significantly for no loss in testing coverage.