Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove brew update command from ci #2445

Merged
merged 1 commit into from
Jul 5, 2023
Merged

remove brew update command from ci #2445

merged 1 commit into from
Jul 5, 2023

Conversation

collinc97
Copy link
Collaborator

@collinc97 collinc97 commented Jul 5, 2023

Issue

Run brew update
error: Could not read 050b5490e7bb098f70f3de925431a24622f2d64c
fatal: revision walk setup failed
error: https://github.com/Homebrew/homebrew-cask did not send all necessary objects

GitHub actions CI failing due to broken brew update command on macos m1 platforms

Breaking in all current PRs.
Example https://github.com/AleoHQ/leo/actions/runs/5463254559/jobs/9943707212?pr=2443

Fix

Removing brew update from CI as referenced in https://github.com/orgs/Homebrew/discussions/4612#discussioncomment-6356325

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2445 (4ad753d) into testnet3 (c0b2778) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           testnet3    #2445   +/-   ##
=========================================
  Coverage     79.23%   79.23%           
=========================================
  Files           154      154           
  Lines          4868     4868           
  Branches       4867     4867           
=========================================
  Hits           3857     3857           
  Misses         1011     1011           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@collinc97 collinc97 marked this pull request as ready for review July 5, 2023 22:39
@d0cd d0cd self-requested a review July 5, 2023 22:43
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@collinc97 collinc97 merged commit fd162a4 into testnet3 Jul 5, 2023
8 checks passed
@collinc97 collinc97 deleted the fix/ci-homebrew branch July 5, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants