Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support ChaCha::rand_* #2433

Merged
merged 6 commits into from
Jun 29, 2023
Merged

[Feature] Support ChaCha::rand_* #2433

merged 6 commits into from
Jun 29, 2023

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Jun 28, 2023

This PR supports ChaCha::rand_*() in finalize blocks where * is any primitive type.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2433 (2f53dee) into testnet3 (c373b89) will increase coverage by 0.10%.
The diff coverage is 92.30%.

@@             Coverage Diff              @@
##           testnet3    #2433      +/-   ##
============================================
+ Coverage     79.09%   79.20%   +0.10%     
============================================
  Files           155      155              
  Lines          4822     4851      +29     
  Branches       4821     4850      +29     
============================================
+ Hits           3814     3842      +28     
- Misses         1008     1009       +1     
Impacted Files Coverage Δ
compiler/span/src/symbol.rs 84.61% <ø> (ø)
...er/passes/src/code_generation/visit_expressions.rs 82.01% <60.00%> (-0.83%) ⬇️
compiler/ast/src/functions/core_function.rs 100.00% <100.00%> (ø)
...iler/passes/src/type_checking/check_expressions.rs 82.62% <100.00%> (+0.17%) ⬆️
compiler/passes/src/type_checking/checker.rs 96.63% <100.00%> (+1.12%) ⬆️
...rors/src/errors/type_checker/type_checker_error.rs 79.20% <100.00%> (+0.20%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@collinc97 collinc97 merged commit b236918 into testnet3 Jun 29, 2023
8 checks passed
@collinc97 collinc97 deleted the feat/rand-without-seed branch June 29, 2023 04:02
Copy link
Collaborator

@bendyarm bendyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants