Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a metric for invalid ZKAP attempts #265

Closed
wants to merge 48 commits into from
Closed

Add a metric for invalid ZKAP attempts #265

wants to merge 48 commits into from

Commits on Nov 19, 2021

  1. Metrics: Add test for metric file writing scaffolding

    @exarkun
    exarkun committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    3f374bb View commit details
    Browse the repository at this point in the history

  2. Metrics: Implement regular writing of metrics to .prom file

    @exarkun
    exarkun committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    8377166 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Give ZKAPAuthorizerStorageServer a default registry so tests work again

    @exarkun
    exarkun committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    4b31b56 View commit details
    Browse the repository at this point in the history

  2. Add a counter of valid spent passes on the storage server

    @exarkun
    exarkun committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    326ff62 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. just use integer number of seconds in configuration 

    isodate duration parser has some bugs
    @exarkun
    exarkun committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    c788f60 View commit details
    Browse the repository at this point in the history

  2. Replace the ZKAP spending counter with a histogram

    @exarkun
    exarkun committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    b89e84d View commit details
    Browse the repository at this point in the history

  3. factor metric reading helpers out

    @exarkun
    exarkun committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    6e24ebe View commit details
    Browse the repository at this point in the history

  4. [wip]

    @exarkun
    exarkun committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    8ecfcb6 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. test a boolean, for clarity

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    457b269 View commit details
    Browse the repository at this point in the history

  2. Add helpers for computing and observing spending metrics

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    d791deb View commit details
    Browse the repository at this point in the history

  3. add missing argument to after_bucket

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    8938664 View commit details
    Browse the repository at this point in the history

  4. add metric for add_lease operation

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    d004d91 View commit details
    Browse the repository at this point in the history

  5. pyflakes

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    ce47c17 View commit details
    Browse the repository at this point in the history

  6. black

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    31b1518 View commit details
    Browse the repository at this point in the history

  7. isort

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    1481e8a View commit details
    Browse the repository at this point in the history

  8. link to dependency PR that helps

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    0a562ef View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/main' into 141.serverside-promet… 

    …heus-metrics
    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    75dfc52 View commit details
    Browse the repository at this point in the history

  10. fix merge lints

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    3beda67 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/main' into 141.serverside-promet… 

    …heus-metrics
    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    5dd2668 View commit details
    Browse the repository at this point in the history

  12. use observe_spending_successes

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    721d24e View commit details
    Browse the repository at this point in the history

  13. simplify successful spending metrics 

    Let's see how far we get with just this simpler version.  We now have a
histogram for number of zkaps spent, bucketed by the size of individual spend
operations.

Also implement it for mutables
    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    e0e8bfb View commit details
    Browse the repository at this point in the history

  14. somewhat simplify tests by clearing metrics before each example

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    a9e8702 View commit details
    Browse the repository at this point in the history

  15. observe immutable spending success only after success

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    30632e7 View commit details
    Browse the repository at this point in the history

  16. black

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    3fcced5 View commit details
    Browse the repository at this point in the history

  17. make sure we put an integer in the config

    @exarkun
    exarkun committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    a204243 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. fix prometheus on windows, maybe

    @exarkun
    exarkun committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    df257e8 View commit details
    Browse the repository at this point in the history

  2. black

    @exarkun
    exarkun committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    9610054 View commit details
    Browse the repository at this point in the history

  3. do not let write_to_textfile raise an exception to LoopingCall 

    Also make the metrics path's parent directory if necessary
    @exarkun
    exarkun committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    09ef63c View commit details
    Browse the repository at this point in the history

  4. add missing type annotation import

    @exarkun
    exarkun committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    58eaeb2 View commit details
    Browse the repository at this point in the history

  5. get the right eliot ...

    @exarkun
    exarkun committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    56476d1 View commit details
    Browse the repository at this point in the history

  6. return the safe writer!

    @exarkun
    exarkun committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    e3b858e View commit details
    Browse the repository at this point in the history

  7. go away, Windows

    @exarkun
    exarkun committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    9b0dd25 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Use the attr.ib default decorator 

    It's more specific and less powerful, therefore more expressive and safe.

Co-authored-by: Tom Prince <[email protected]>
    @exarkun @tomprince
    exarkun and tomprince authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    d82223b View commit details
    Browse the repository at this point in the history

  2. explain what we're working around a little bit more

    @exarkun
    exarkun committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    a3b200a View commit details
    Browse the repository at this point in the history

  3. link to the issue where there's some discussion about clear()

    @exarkun
    exarkun committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    4d4b214 View commit details
    Browse the repository at this point in the history

  4. rename _get_buckets to something reflecting metricsyness

    @exarkun
    exarkun committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    3ab1b2f View commit details
    Browse the repository at this point in the history

  5. note about why we only have this assertion

    @exarkun
    exarkun committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    77296ac View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. don't record allocate_buckets metrics before success 

    The test demonstrates this now by depending on part of the successful result
from the underlying storage server object.
    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8821dd0 View commit details
    Browse the repository at this point in the history

  2. verify add_lease metric is recorded after we check pass counts

    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    23d2f18 View commit details
    Browse the repository at this point in the history

  3. only record add_lease successful spending if it is successful

    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    85d05c6 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into 141.serverside-promet… 

    …heus-metrics
    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    f2a5049 View commit details
    Browse the repository at this point in the history

  5. only record mutable pass spending if it is successful

    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    e7be7c6 View commit details
    Browse the repository at this point in the history

  6. give read_count and read_bucket better names 

    also rename and clarify the read_bucket `size` parameter
    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    ee4b735 View commit details
    Browse the repository at this point in the history

  7. link to upstream issue about better testing APIs

    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    405fe58 View commit details
    Browse the repository at this point in the history

  8. do structured matching in the metrics writer test

    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    2938889 View commit details
    Browse the repository at this point in the history

  9. remove unused import

    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    378cf91 View commit details
    Browse the repository at this point in the history

  10. rejected zkap metric

    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1617ffa View commit details
    Browse the repository at this point in the history

  11. docstring and type signature woo

    @exarkun
    exarkun committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    a509c28 View commit details
    Browse the repository at this point in the history