-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for lease maintenance behavior #255
Conversation
Codecov Report
@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 94.40% 94.49% +0.09%
==========================================
Files 49 50 +1
Lines 4144 4195 +51
Branches 532 537 +5
==========================================
+ Hits 3912 3964 +52
+ Misses 190 187 -3
- Partials 42 44 +2
Continue to review full report at Codecov.
|
avoids ambiguities and implementation problems of iso8601 duration strings go back to aniso8601 dependency, since we no longer get anything distinctive from isodate
Co-authored-by: Tom Prince <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It would be nice if the config section to read from was not hard-coded in a leaf function, but that isn't blocking.
""" | ||
Helpers for reading values from the Tahoe-LAFS configuration. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to have separate modules for client and server config. Other than empty_config
(which I guess is a test fixture), all the stuff here is client specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be, yea. Since this project started it has become clear that two different plugins may have made more sense than a single plugin with such a tightly coupled implementation. We could probably try to keep the pieces as separate as possible until a more definitive decoupling happens. I'll keep it in mind for future development.
Fixes #169
Probably done but I'm going to integrate it w/ GridSync before saying so for sure.Per discussion elsewhere, GridSync also/instead needs a different integration point for answering the question it has. So this is probably fine as-is (and maybe also not useful in the near term - but still maybe useful in the long term, and at least not harmful right now).