Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a metric for invalid ZKAP attempts #265

Closed
wants to merge 48 commits into from
Closed

Conversation

exarkun
Copy link
Collaborator

@exarkun exarkun commented Dec 6, 2021

Fixes #260

This does not expose the total number of ZKAPs that are considered invalid. Instead it just counts the number of operations attempted where an invalid ZKAP is observed. Maybe this will provide sufficient visibility. There is still only one way we can recognize a pass as invalid - invalid signature - so there's only one label on this metric. It should be straightforward to add more ways as we define them.

isodate duration parser has some bugs
Let's see how far we get with just this simpler version.  We now have a
histogram for number of zkaps spent, bucketed by the size of individual spend
operations.

Also implement it for mutables
Also make the metrics path's parent directory if necessary
@exarkun
Copy link
Collaborator Author

exarkun commented Apr 4, 2022

Maybe a good idea but ... maybe not? No demonstrated utility yet, anyway. Also it ended up being a lot more complex than I anticipated. Maybe this is something to look into in the future but I'm closing it for now so that the list of open PRs reflects active development efforts.

@exarkun exarkun closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant