Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some domains can be optional - rename cdn to local_cdn to be more clear #117

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Some domains can be optional - rename cdn to local_cdn to be more clear #117

merged 1 commit into from
Sep 24, 2024

Conversation

binaryoverload
Copy link

Resolves my mistake

Changes:

  • Allow the local CDN domain to be optional - it doesn't have to be specified if you're using S3

jonbarrow
jonbarrow approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@jonbarrow jonbarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonbarrow jonbarrow merged commit 988ce63 into PretendoNetwork:dev Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonbarrow jonbarrow jonbarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binaryoverload @jonbarrow