Increase the batch size of rows during the database backup #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Quetzacoalt91
commented
Sep 10, 2024
Quetzacoalt91
commented
| Questions | Answers |
|---|---|
| Description? | Following an ugprade attempt made on a production like shop, we discovered the database backup takes too much time. It did not complete after a whole day of work while a save of the same database via PhpMyAdmin takes a couple of minutes. This PRs tries some changes to see the impact on the process. |
| Type? | improvement |
| BC breaks? | Nope |
| Deprecations? | Nope |
| Fixed ticket? | / |
| Sponsor company | @PrestaShopCorp |
| How to test? | Backups are faster |
Quetzacoalt91
commented
Sep 10, 2024
|
With this PR, a backup that was taking more than a day before (we could not reach the end), completes now in ~3h30. This is a good step ahead, but there is still room for improvement. |
Quetzacoalt91
force-pushed
the
increase-batch-size-during-backup-db
branch
from
bce9fd1
to
070ec11
Compare
|
Replaced by #894 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.