Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 9.0.0.sql #691

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update 9.0.0.sql #691

wants to merge 1 commit into from

Conversation

Kaikina
Copy link

@Kaikina Kaikina commented Apr 18, 2024 •
edited by Quetzacoalt91
Loading

See PR PrestaShop/PrestaShop#35843

Questions Answers
Description? Goes along the PR PrestaShop/PrestaShop#35843 from prestashop/prestashop. A new configuration key is added to the core. It should be inserted in the next version autoupgrade script.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? NA
Sponsor company Evolutive
How to test? NA

@Kaikina Kaikina mentioned this pull request Apr 18, 2024
Open
@Kaikina
Copy link
Author

Kaikina commented Apr 18, 2024

Related PR : PrestaShop/PrestaShop#35843

LouisAUTHIE
LouisAUTHIE previously approved these changes Apr 18, 2024
View reviewed changes
@Quetzacoalt91 Quetzacoalt91 added the Blocked Status: The issue is blocked by another task label Apr 19, 2024
nicosomb
nicosomb previously approved these changes Apr 30, 2024
View reviewed changes
@Hlavtox
Copy link
Contributor

Hlavtox commented May 22, 2024

@Kaikina Rebase is needed

@Kaikina Kaikina dismissed stale reviews from nicosomb and LouisAUTHIE via 8ebd38a May 27, 2024 09:18
@Kaikina
Copy link
Author

Kaikina commented May 27, 2024

Done @Hlavtox

Hlavtox
Hlavtox requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR broken, some merge things got into it

@Kaikina
Update 9.0.0.sql
ca09f97 
See PR#35843
@Kaikina
Copy link
Author

Kaikina commented May 30, 2024

@Hlavtox how about now ?

@ga-devfront ga-devfront requested a review from Hlavtox June 20, 2024 13:23
@matks matks removed the Blocked Status: The issue is blocked by another task label Jun 25, 2024
@AureRita
Copy link

AureRita commented Jul 8, 2024

Hi @Kaikina

Currently I see that your PR isn't merged on develop, I'll block this PR until your PR 'll be merged

Thank you

@AureRita AureRita added the Blocked Status: The issue is blocked by another task label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hlavtox Hlavtox Hlavtox approved these changes

@ga-devfront ga-devfront ga-devfront approved these changes

@Touxten Touxten Touxten approved these changes

@nicosomb nicosomb nicosomb left review comments

@LouisAUTHIE LouisAUTHIE LouisAUTHIE left review comments

Assignees
No one assigned
Labels
Blocked Status: The issue is blocked by another task waiting for QA
Projects
PR Dashboard
Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Kaikina @Hlavtox @AureRita @nicosomb @ga-devfront @LouisAUTHIE @Touxten @matks @Quetzacoalt91 @ps-jarvis