chore: use ephemeral workspaces in tests #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts with 'nonamedreturns' linter, and named returns isn't always used or recommended.
Adds two helpers to create random values and random workspaces to be used as ephemeral resources.
mitchnielsen
added
the
maintenance
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
force-pushed
the
ephemeral-workspaces-in-tests
branch
from
58b8093
to
ed98acf
Compare
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
Uses the new ephemeral workspace helpers to create the new, random workspace.
mitchnielsen
force-pushed
the
ephemeral-workspaces-in-tests
branch
from
c39ac79
to
f621e00
Compare
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
mitchnielsen
force-pushed
the
ephemeral-workspaces-in-tests
branch
from
f621e00
to
53f1fe0
Compare
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
Needed to set '10' as a constant to work around the 'mnd' linter.
mitchnielsen
force-pushed
the
ephemeral-workspaces-in-tests
branch
from
53f1fe0
to
9b8545a
Compare
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
force-pushed
the
ephemeral-workspaces-in-tests
branch
from
0144114
to
8941ce9
Compare
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
force-pushed
the
ephemeral-workspaces-in-tests
branch
from
8941ce9
to
78ca434
Compare
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
force-pushed
the
ephemeral-workspaces-in-tests
branch
from
78ca434
to
6dc37d4
Compare
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
|
@parkedwards - I got the ball rolling here and will pick it back up after the move 👍🏼 |
|
awesome - thank you @mitchnielsen |
parkedwards
reviewed
Jun 19, 2024
Comment on lines
+83
to
+85
| func NewRandomPrefixedString() string { | ||
| return TestAccPrefix + acctest.RandStringFromCharSet(RandomStringLength, acctest.CharSetAlphaNum) | ||
| } |
…t into ephemeral-workspaces-in-tests
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
…t into ephemeral-workspaces-in-tests
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
|
@parkedwards - after some thinking, I wonder if it's nicer to just merge this one before it gets too big. Instead of doing it all in one big change, we can use this one to add the new helpers and implement it in a few places, and then I'll follow up with further implementation in separate PR(s). If you disagree just lmk and I'm happy to continue with making the changes here 👍🏼 |
parkedwards
approved these changes
Jul 17, 2024
totally reasonable to me - we could also do something like "if you touch some code, update the tests" |
|
No worries at all, it's helped me get up to speed on how all of this works together 👍🏼 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #218
To do