Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Moved nginx unit into our codebase #25055

Open
wants to merge 11 commits into
base: feat/dockerfiles
Choose a base branch
from
Open

feat: Moved nginx unit into our codebase #25055

wants to merge 11 commits into from
+191 −5

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Sep 18, 2024 •
edited
Loading

Problem

Closes #25052

Changes

  • Changes the base to just the python image
  • Pulls in the bits we need for nginx unit without using their base (so we don't get caught out by them changing their base like they recently did)

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite changed the base branch from master to feat/dockerfiles September 20, 2024 11:32
@benjackwhite benjackwhite requested a review from a team September 20, 2024 11:34
@benjackwhite benjackwhite marked this pull request as ready for review September 20, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daesgar Daesgar Daesgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate our own nginx unit installation rather than using the docker image
2 participants
@benjackwhite @Daesgar