chore(debt): Move all static style values to classes #25035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
approved these changes
Sep 18, 2024
Twixes
reviewed
Sep 20, 2024
| }} | ||
| > | ||
| {onClose ? ( | ||
| <div | ||
| onClick={onClose} | ||
| className="absolute origin-top-left bg-black text-white rounded-full w-6 h-6 z-[7] flex items-center justify-around text-center cursor-pointer" |
There was a problem hiding this comment.
I don't think we have a color var black defined in the $colors list of vars.scss – probably should be:
Suggested change
| className="absolute origin-top-left bg-black text-white rounded-full w-6 h-6 z-[7] flex items-center justify-around text-center cursor-pointer" | |
| className="absolute origin-top-left bg-[#000] text-white rounded-full w-6 h-6 z-[7] flex items-center justify-around text-center cursor-pointer" |
Twixes
reviewed
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #16826 by replacing all static styles with their class equivalents.
How did you test this code?
I manually verified some changes but I am not able to get
pnpm test:visualworking correctly on my system. Will share the results once I do. I did not want it to be a blocker for pushing the code changes that I have done.