Fixed connection hang, segfault, and unexpected warnings issues after internet connection loss. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This counter is intended to detect possible authentication issues (e.g., incorrect key). Socket errors, typically some form of "internet connection not available," should not count against that.
…ng cases. The Polaris network now sends an RTCM 1029 text message in response to an authentication failure or similar error. The client no longer receives 0 bytes when an authentication token is rejected. This change avoids misleading warnings when authentication is valid but position is not supplied, etc. We now return POLARIS_CONNECTION_CLOSED when the connection is closed without an authentication error, including if we do not receive any data from the network, and only return POLARIS_FORBIDDEN if we suspect an authentication issue.
The P1_SetAddress() does not currently support IPv6. This may change in the future.
Otherwise, ASAN needs to be manually loaded via LD_PRELOAD.
… out." We cannot remove these. Internally, polaris.c accesses them if POLARIS_USE_TLS is enabled _when polaris.c is compiled_. But if the user application does not set POLARIS_USE_TLS when they compile and instantiate PolarisContext_s, the context they create will be smaller than polaris.c is expecting and will cause a buffer overflow.
Without these, loss of internet connection could get treated as an unexpected socket error, rather than a timeout, and Polaris_Run() might exit its while loop and never reconnect.
adamshapiro0
force-pushed
the
failed-reconnect
branch
from
3a7cd21
to
d56e7ef
Compare
adamshapiro0
changed the title
anathan
approved these changes
Mar 29, 2024
| else if (context->total_bytes_received > 0) { | ||
| P1_Print( | ||
| "Warning: Polaris connection closed with an error response. Is " | ||
| "your authentication token valid?\n"); |
There was a problem hiding this comment.
Not without adding an RTCM parser. If we hit an errno it will be printed above before we get here, but if we get an error notification from the server it comes as an RTCM 1029 message. We could add functionality to parse it and verify the CRC, but we don't have that in this library currently.
adamshapiro0
force-pushed
the
failed-reconnect
branch
from
f8c7a63
to
c5b7f1c
Compare
adamshapiro0
force-pushed
the
failed-reconnect
branch
from
c5b7f1c
to
d1ac61b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes
polaris_client.ccgethostname()(IPv6 not currently supported)Polaris_Send*()position send function segfault if SSL context is not connected