Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(currentUser): PPT-840 Add JWT check to ensure public access to resources with GET requests #363

Closed
wants to merge 3 commits into from
Closed

feat(currentUser): PPT-840 Add JWT check to ensure public access to resources with GET requests #363

wants to merge 3 commits into from

Conversation

grkek
Copy link

@grkek grkek commented Oct 11, 2023

No description provided.

stakach
stakach requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid x-api-keys fail after this change with

{
    "error": "unknown X-API-Key"
}

probably the reason the specs fail - you can see the specs passing in this pull #364

@grkek grkek requested a review from stakach November 13, 2023 05:05
@github-actions github-actions bot added the type: enhancement new feature or request label Nov 13, 2023
@grkek grkek assigned stakach and unassigned grkek Nov 13, 2023
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Nov 13, 2023
@jeremyw24
Copy link

@stakach can you please review this PR again?

@stakach
Copy link
Member

stakach commented Nov 27, 2023

fixed in 650b267

@stakach stakach closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naqvis naqvis Awaiting requested review from naqvis

@chillfox chillfox Awaiting requested review from chillfox

@stakach stakach Awaiting requested review from stakach

Assignees

@stakach stakach

Labels
type: enhancement new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grkek @jeremyw24 @stakach