Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Box, Hermite, and Lagrange filters #37

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

RunDevelopment
Copy link
Contributor

As not promised, some more filters :)

This PR adds the box, Hermite, and Lagrange filters. Some notes:

  • Box is a very simple filter, so there's not much to say.
  • Hermite uses the same implementation as the other cubic filters, but with a different support window.
  • I just copied Lagrange from ImageMagick. I checked and it produces the same results as ImageMagick.

Related to #12.

@kornelski
Copy link
Collaborator

This is making hard to choose the right filter. Can you expand doc comments on each filter describing its unique advantages and disadvantages?

@RunDevelopment
Copy link
Contributor Author

Since a lot of filters are variants of each other with very similar properties, I tried to explain the relation between filters. I hope that is good enough.

I also linked to the filter explanation article from the README, because I feel like this article explains it lot better than I ever could.

@kornelski kornelski merged commit d373b8c into PistonDevelopers:master Dec 7, 2023
@kornelski
Copy link
Collaborator

Thank you

@RunDevelopment RunDevelopment deleted the more-filter-types branch December 7, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants