[Major] allow to load mocks on non-rpi systems #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shutdown hook is hooked into the JVM and is executed when the JVM stops. This can be beneficial when the application is not managing pi4j's life cycle, but when an application wants to properly manage the life cycle, then this can be detrimental to the shutdown sequence of the application. This change allows such an application to disable this feature. The shutdown hook is still enabled by default, a future version might decide to disable it by default.
This removes the
Pi4J.newAutoContextAllowMocks()
function, as we now detect these systems using:
BoardInfoHelper.runningOnRaspberryPi()
This is a breaking API change, but should satisfy people having to write special code to load the mock in tests, as this happens automatically now.
If a mock is to be loaded on the Raspberry Pi, then one can still do this using the following code:
Pi4J.newContextBuilder().autoDetectMockPlugins().build();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
Pi4J.newAutoContextAllowMocks()
function, as we now detect these systems using:
BoardInfoHelper.runningOnRaspberryPi()
This is a breaking API change, but should satisfy people having to write special code to load the mock in tests, as this happens automatically now.
If a mock is to be loaded on the Raspberry Pi, then one can still do this using the following code:
Pi4J.newContextBuilder().autoDetectMockPlugins().build();