Add conversion support for Qiskit's NoiseModels
#569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #569 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 7 8 +1
Lines 554 734 +180
==========================================
+ Hits 554 734 +180 ☔ View full report in Codecov by Sentry. |
…pennylane-qiskit into noise-model-convert
obliviateandsurrender
changed the title
NoiseModelsNoiseModels
pennylane_qiskit/noise_models.py
Outdated
Comment on lines
418
to
420
| if noise_model._default_readout_error or noise_model._local_readout_errors: | ||
| warn("Readout errors are not supported currently and will be skipped.") | ||
|
|
There was a problem hiding this comment.
@trbromley we have in the requirements that if readout noise is present, PennyLane raises an error. But, I'm wondering if raising a warning instead and skipping the readout noise makes more sense? 🤔
|
A minimalistic version of this PR is implemented here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Add support for converting Qiskit's noise models to PennyLane's noise models.
Description of the Change:
noise_models.pycontains helper methods for particular thingsErrorobject to that of a corresponding Qiskit's instructions consisting of their Pauli or Kraus representationNoiseModelobject to a list of PennyLane Channel objects that are constructed based on the above description.converter.pycontains theload_noise_modelmethod, which accepts a Qiskit noise model along with some mentioned keyword arguments and returns the corresponding PennyLane noise model.Benefits:
Noise model construction becomes easier and hardware noise models can be better studied.
Possible Drawbacks:
Related GitHub Issues: [sc-68045]