Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tweaks #697

Merged
merged 8 commits into from
Aug 29, 2024
Merged

More tweaks #697

merged 8 commits into from
Aug 29, 2024

Conversation

bakert
Copy link
Member

@bakert bakert commented Aug 29, 2024

  • Avoid broken images for series with no logo uploaded
  • Apply fixes from StyleCI
  • As much of PSR12 coding standard that phpcs can do automatically
  • Centralize session_start in lib.php instead of having to put it in every file
  • Remove no-longer-used sidebar.php
  • Remove unused function params
  • Refactor eventreport into a slightly saner style
  • Remove unreferenced old 2013 bracket page
  • Don't emit header twice on event report page
  • Attempt to further standardize times for human consumption
  • Remove now-unused time formatting js stuff
  • Banish all remnants of (deprecated) strftime
  • Bring start time down on its own line to make room for event title
  • Get rid of rather flimsy out of service mechanism
  • Convert homepage to using page helper function
  • More homepage improvements
  • Clean up some old comments
  • Use our new standarsized time module for next event of each series

bakert and others added 8 commits August 29, 2024 13:13
For some reason it is also incredibly slow so this is doubly good.
This was already squished but increased font size made it silly.
This only affected the homepage so it's not really safe to use.
It does a tiny bit of deduplication. Might be a nice step towards a bigger refactor.
The round is kind of floating in space far from the tournament name if it's short but at least it isn't weirdly aligned.
@bakert bakert merged commit cd764c6 into dev Aug 29, 2024
6 checks passed
@bakert bakert deleted the more branch August 29, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants