Merge pull request #751 from PennyDreadfulMTG/debug-sessions

Don't store empty sessions, really this time
PennyDreadfulMTG · Sep 9, 2024 · 8c2f6e9 · 8c2f6e9
2 parents cad3d04 + 5e7867f
commit 8c2f6e9
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/gatherling/Auth/Session.php b/gatherling/Auth/Session.php
@@ -51,13 +51,13 @@ private static function save(): void
             self::clear($token);
             return;
         }
+        if (empty($_SESSION)) {
+            return;
+        }
         if (!$token) {
             $token = bin2hex(random_bytes(32));
         }
         $details = json_encode($_SESSION);
-        if ($details === '[]') {
-            Log::warning('Storing an empty session for some reason', ['token' => $token, 'session' => $_SESSION]);
-        }
         $expiry = time() + self::$LIFETIME;
         $sql = '
             INSERT INTO