Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (neuro)docker image #81

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

yarikoptic
Copy link
Contributor

@yarikoptic yarikoptic commented Jun 12, 2024

not even know if bidsonym is still worth (re)trying on my dataset but can't reliably do it without getting a container ;-) hence decided to possibly duplicate efforts with @Remi-Gau of

and see the container built.

If finished, closes #79

Ideally

  • see it finish building cleanly
  • see it work on some sample
    • there are warnings (Fresh warnings to tackle #84) and may be that is why deface_wf report in index.html has nothing really.. so it kinda works but still might be buggy
  • add bids-validator-deno . I already added deno into recipe to be installed in conda, so then we could install new schema-based validator there

current gotchas

(dev3) yoh@typhon:/mnt/DATA/data/yoh/BIDSonym$ docker run -it --rm bidsonym:local
docker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/neurodocker/startup.sh": stat /neurodocker/startup.sh: no such file or directory: unknown.
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
gif-your-nifti 0.2.1 requires imageio<2.28, but you have imageio 2.34.1 which is incompatible.
Successfully installed argparse-1.4.0 bidsonym-0.0.6+17.g8417c18.dirty citeproc-py-0.6.0 duecredit-0.10.2 imageio-2.34.1 nilearn-0.10.4 scikit-learn-1.5.0 threadpoolctl-3.5.0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
Removing intermediate container 6706dd6d886d

…from neurodesk fsl recipe

failed with FSL installation failure

ERROR occurred during installation!
    This command returned an error: /opt/fsl-6.0.6.4/bin/conda env update
-p /opt/fsl-6.0.6.4 -f /tmp/tmp_ynzfnbz/fsl-6.0.6.4_linux-64.yml
@yarikoptic
Copy link
Contributor Author

note that apparently there is no credentials added for docker pushes so no attempt to build even made.

Run docker/login-action@v2
  with:
    ecr: auto
    logout: true
Error: Username and password required

I will reorder commands so we could see if it at least builds ok etc.

Otherwise if no t1w files found, the variable t1w would not get populated in
the loop at all and cause the crash.  But it also does not make much sense to
return only the last hit in the loop. Checking the workflow, it seems
outputs are not used at all anyways, so we are gonna try to return a list
* gh-yarikoptic/bfs:
  Return lists of defaced t1w and t2w and define it for t2w
  [DATALAD RUNCMD] run codespell throughout fixing typo automagically
  [DATALAD RUNCMD] Fix bidsonym/run_deeid.py brainextration typo which triggered this all
  [DATALAD RUNCMD] Do interactive fixing of typos
  [DATALAD RUNCMD] run codespell throughout fixing typo automagically
  Add rudimentary codespell config
  Add github action to codespell master on push and PRs
* gh-yarikoptic/bfs:
  BF: more of defining defaults to not cause obnoxious crashes
@yarikoptic yarikoptic marked this pull request as ready for review June 13, 2024 22:38
@yarikoptic
Copy link
Contributor Author

I am done with this as far I consider it done. Includes fixes from

@yarikoptic
Copy link
Contributor Author

@PeerHerholz please review&merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please provide new docker image
1 participant