Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct AsnProp type for CRLs RevocationInfoChoices #100

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: correct AsnProp type for CRLs RevocationInfoChoices #100

merged 1 commit into from
Aug 1, 2024

Conversation

dhensby
Copy link
Contributor

@dhensby dhensby commented Jul 25, 2024 •
edited
Loading

This fixes #97

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10096076388

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 86.89%
Totals Coverage Status
Change from base Build 6611970646: -0.03%
Covered Lines: 2583
Relevant Lines: 2841
💛 - Coveralls

@dhensby dhensby mentioned this pull request Jul 25, 2024
Closed
@dhensby
Copy link
Contributor Author

dhensby commented Aug 1, 2024

cc @microshine 🙏

@microshine microshine merged commit 8cbd306 into PeculiarVentures:master Aug 1, 2024
1 of 2 checks passed
@dhensby dhensby deleted the pulls/cms-crls-fix branch August 1, 2024 16:30
@microshine
Copy link
Contributor

Thank you, @dhensby, for the update. I've accepted the changes and published a new version: @peculiar/[email protected].

@dhensby
Copy link
Contributor Author

dhensby commented Aug 1, 2024

Thanks so much, and sorry for the pings - really grateful for getting this released 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to parse serialized SignedData with crls
3 participants
@dhensby @coveralls @microshine